feat: transparent background and hidden send button#11
Open
clancywist wants to merge 1 commit into
Open
Conversation
- Set containerView.backgroundColor to .clear instead of hardcoded grey - Remove background color reset in traitCollectionDidChange so consumer styles are not overridden on trait changes - Hide send button completely (isHidden) when sendButtonEnabled is false instead of only dimming it - Reduce textContainerInset.right from 56 to 12 so the text input reclaims space when the send button is not present Closes launchtodayhq#10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #10.
containerView.backgroundColoris now.clearinstead of a hardcoded grey, letting consumers control the background via their own wrapper or styles.containerView.backgroundColor = composerBackgroundColor()line fromtraitCollectionDidChangeso consumer-provided backgrounds survive dark/light mode switches.sendButtonEnabled={false}, the send button is now fully hidden (isHidden = true) instead of just dimmed (alpha 0.4).textContainerInset.rightfrom56to12so the text input uses the full width when the send button is not present.Changed file
ios/KeyboardComposerView.swift— 4 targeted changes, no new files or APIs.Test plan
<ChatComposer sendButtonEnabled={false} />and verify the send button is completely invisible with no reserved space on the right<ChatComposer />(default) and verify the send button appears and functions normally