Skip to content

fix(json): emit canonical camelCase JSON wire keys #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hortison wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −15
Open

fix(json): emit canonical camelCase JSON wire keys #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions layouts/lab/single.json.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
"description": {{ .Content | plainify | jsonify }},
"weight": {{ $p.weight | jsonify }},
"type": "lab",
"starter_catalog_link": {{ $p.starter_catalog_link | jsonify }},
"starter_embed_link": {
"starterCatalogLink": {{ $p.starter_catalog_link | jsonify }},
"starterEmbedLink": {
"src": {{ $p.starter_embed_link.src | jsonify }},
"id": {{ $p.starter_embed_link.id | jsonify }}
},
"answer_catalog_link": {{ $p.answer_catalog_link | jsonify }},
"answer_embed_link": {
"answerCatalogLink": {{ $p.answer_catalog_link | jsonify }},
"answerEmbedLink": {
"src": {{ $p.answer_embed_link.src | jsonify }},
"id": {{ $p.answer_embed_link.id | jsonify }}
}
Expand Down
6 changes: 3 additions & 3 deletions layouts/partials/common-curricula-properties.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
"permalink": {{ $page.RelPermalink | jsonify }},
"type": {{ $type | jsonify }},
"prerequisites": {{ partial "test/collect-prerequisites.html" $page | jsonify }},
"reading_time": {{ $page.ReadingTime | jsonify }},
"readingTime": {{ $page.ReadingTime | jsonify }},
"competencies": {{ $page.Params.competencies | jsonify }},
"objectives": {{ $page.Params.objectives | jsonify }},
"audience": {{ $page.Params.audience | jsonify }},
"prerequisite_knowledge": {{ $page.Params.prerequisite_knowledge | jsonify }},
"related_resources": {{ $page.Params.related_resources | jsonify }}
"prerequisiteKnowledge": {{ $page.Params.prerequisite_knowledge | jsonify }},
Copy link
Copy Markdown
Contributor

@CodexRaunak CodexRaunak May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fields prerequisite_knowledge, related_resources, and additional_attributes, needs to be changed to camelCase on cloud, after the theme updates.

"relatedResources": {{ $page.Params.related_resources | jsonify }}

16 changes: 8 additions & 8 deletions layouts/partials/learning-path.json.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"id": {{ $id | jsonify }},
"level": {{ (trim $level " \n\r\t") | jsonify }},
"slug": {{ $slug | jsonify }},
"org_id": {{ $uuid | jsonify }},
"orgId": {{ $uuid | jsonify }},
"type": {{ .Params.Type | jsonify }},
"visibility": {{ or .Params.Visibility "public" | jsonify }},
"status": {{ or .Params.Status "ready" | jsonify }},
Expand Down Expand Up @@ -52,16 +52,16 @@
"permalink": {{ .RelPermalink | jsonify }},
"categories": {{ .Params.Categories | jsonify }},
"tags": {{ .Params.Tags | jsonify }},
"total_courses": {{ len (where .Pages "Type" "course") }},
"total_tests": {{ len (where .Pages "Type" "test") }},
"total_modules": {{ len (where .Pages "Type" "module") }},
"total_pages": {{ len (where .Pages "Type" "page") }},
"totalCourses": {{ len (where .Pages "Type" "course") }},
"totalTests": {{ len (where .Pages "Type" "test") }},
"totalModules": {{ len (where .Pages "Type" "module") }},
"totalPages": {{ len (where .Pages "Type" "page") }},
"competencies": {{ .Params.competencies | jsonify }},
"objectives": {{ .Params.objectives | jsonify }},
"audience": {{ .Params.audience | jsonify }},
"prerequisite_knowledge": {{ .Params.prerequisite_knowledge | jsonify }},
"related_resources": {{ .Params.related_resources | jsonify }},
"additional_attributes": {{ .Params.additional_attributes | jsonify }},
"prerequisiteKnowledge": {{ .Params.prerequisite_knowledge | jsonify }},
"relatedResources": {{ .Params.related_resources | jsonify }},
"additionalAttributes": {{ .Params.additional_attributes | jsonify }},
"children": [
{{- range $j, $c := .Pages }}
{{- if $j }},{{ end }}
Expand Down
Loading