Skip to content

[Docs] Fix 404 asset base path for previews #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodexRaunak wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −0
Open

[Docs] Fix 404 asset base path for previews #1066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions layouts/partials/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,19 @@
<meta name="robots" content="noindex, nofollow">
{{ end -}}

{{- if eq .Kind "404" }}
<script>
(function () {
var path = window.location.pathname;
var previewPath = path.match(/^((?:\/[^/]+)?\/pr-preview\/pr-[^/]+\/)/);
var basePath = previewPath ? previewPath[1] : "/";
var base = document.createElement("base");
base.href = basePath;
document.head.insertBefore(base, document.head.firstChild);
})();
Comment on lines +18 to +25
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using var for variable declarations is an outdated practice in modern JavaScript. It is highly recommended to use const (or let if re-assignment is needed) to ensure block-scoping, prevent accidental re-declarations, and improve overall code maintainability and readability.

Suggested change
(function () {
var path = window.location.pathname;
var previewPath = path.match(/^((?:\/[^/]+)?\/pr-preview\/pr-[^/]+\/)/);
var basePath = previewPath ? previewPath[1] : "/";
var base = document.createElement("base");
base.href = basePath;
document.head.insertBefore(base, document.head.firstChild);
})();
(function () {
const path = window.location.pathname;
const previewPath = path.match(/^((?:\/[^/]+)?\/pr-preview\/pr-[^/]+\/)/);
const basePath = previewPath ? previewPath[1] : "/";
const base = document.createElement("base");
base.href = basePath;
document.head.insertBefore(base, document.head.firstChild);
})();

</script>
{{- end }}

<meta property="og:title" content="{{ .Title }}">
<meta property="og:description" content="{{ .Description }}">
<meta property="og:image" content="https://docs.layer5.io/images/layer5-gradient.webp">
Expand Down
Loading