[codex] Fix Polymarket base path issues#2060
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🚀 Storybook preview: https://layerswap.github.io/layerswapapp/pr-preview/pr-2060/ |
babgev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two Polymarket production issues caused by the app being served under
/app: legacy Safe nonce relay calls now includerouter.basePath, and local public images are prefixed with the same base path before going throughnext/image.The relayer helper signatures now require
basePath, so future relay calls do not silently fall back to root/api/...URLs.This resolves both the relay 404 and the Polymarket logo optimizer 400 where
url=/images/polymarket.pngshould beurl=/app/images/polymarket.png.Validation:
git diff --checkpassed; local curl checks show the old optimizer URL returns 400 and the fixed base-path URL returns 200;pnpm exec tsc --noEmitstill fails on existing missing PNG module declarations in FeeDetails and SwapGuide.