This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Open
Conversation
lcodeca
reviewed
Aug 7, 2020
| IMAGE_FOLDER="docker-image" | ||
| GPU=true | ||
| GPU_OPT="--gpus all" | ||
| OPTIRUN=false |
Owner
There was a problem hiding this comment.
optirun does not exist for Mac OSX
lcodeca
reviewed
Aug 7, 2020
| if [[ "$CACHE" = true ]]; then | ||
| echo "Building the docker container using the cache, if present." | ||
| $OPTIRUN_OPT docker build \ | ||
| --build-arg USER_ID=$(id -u ${USER}) \ |
Owner
There was a problem hiding this comment.
This is how the parameters are passed to the Dockerfile.
You can add a command-line parameter to read them from the user instead of pulling them from the system like it's done in Linux.
lcodeca
reviewed
Aug 8, 2020
| #USER alice | ||
|
|
||
| # Working user | ||
| RUN groupadd --gid 197121 alice && \ |
Owner
There was a problem hiding this comment.
UID and GID should not be hardcoded.
lcodeca
reviewed
Aug 8, 2020
|
|
||
| 3. build the docker image using the docker cmd bash script | ||
|
|
||
| `./docker-cmd-windows.sh -n=marl-parking-devel -b -c -r` |
Owner
There was a problem hiding this comment.
This was from our specific project, it should be more generic in a howto.
lcodeca
reviewed
Aug 8, 2020
|
|
||
| 5. use the following command line to run your docker image: | ||
|
|
||
| (of course replace "GroupID, UserID and FolderPath" accordingly |
Owner
There was a problem hiding this comment.
Can this be embedded in docker-cmd-windows.sh with
- DISPLAY
- UID & GID
as command-line parameters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.