ci: make integration tests a mandatory pipeline gate; correct docs - #45
Merged
Conversation
Add a dedicated, required 'Run integration tests' step to the CI workflow so integration tests (tests/integration/) are an unmistakable gate that fails the build if they break, in addition to the combined coverage run. Correct AGENTS.md: the integration tests are fully mocked with the responses library and run offline — they do not make live api.chess.com calls. Codify the mandatory-integration-test policy across AGENTS.md, CLAUDE.md, and the testing / ci-cd standards so it is always validated and never skipped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the integration test suite a permanent, mandatory part of the CI pipeline and corrects out-of-date documentation.
Changes
.github/workflows/ci.yml): add a dedicated, requiredRun integration tests (mandatory gate)step (pytest tests/integration -v) before the combined coverage run, so integration failures unmistakably fail the build and block merge.AGENTS.mdpreviously claimed integration tests "make live calls to api.chess.com" and must "never run in CI without a network." This is inaccurate — every HTTP call intests/integration/is mocked withresponsesand runs fully offline. Updated to reflect reality and codify the mandatory gate.AGENTS.md,CLAUDE.md,.context/standards/testing.md, and.context/standards/ci-cd.md: integration tests are mocked/offline, always validated, and never skipped.Validation
ruff check .— cleanpytest tests/integration— 24 passedCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com