Conversation
ioeddk
reviewed
Feb 24, 2026
Contributor
ioeddk
left a comment
ioeddk
left a comment
There was a problem hiding this comment.
Who will ever set this id or initialize an id for a struct? Is it automatically controlled by Rust or Asterina's scheduler? If it's Asterinas, then are you sure the tid functionality is actually implemented and correct?
Contributor
Author
|
asterinas/ostd/src/task/mod.rs Line 307 in 5435f2e So it's already well defined. |
ioeddk
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the thread ID to all log messages.
I am open to the idea that this is not a good idea and this should not be merged. But I think it's probably generally useful, especially as the number of threads and messages increases.