Conversation
There was a problem hiding this comment.
I don't think we are ready to have a general start.sh file. The name kinda implies it is always run and that's not how we are setting things up yet. Just having start_dropbear.sh seems like a good bet for now. We can setup universal services that already run in the asterinas environment later.
arthurp
left a comment
arthurp
left a comment
There was a problem hiding this comment.
It looks like you have some handling for old Docker containers which don't have dropbear. I'm OK with that. But if there are cases where dropbear might just be missing for other reasons we should figure out why.
Could you add documentation in the readme and maybe other appropriate places? Just a couple of sentences and an example to show what it can do and how to use it.
| echo "Dropbear started (PID $!)." | ||
| lsof -p $! | ||
| else | ||
| echo "WARNING: dropbear not found, should not use run_dropbear!!!" |
There was a problem hiding this comment.
Why would this ever happen? Is this just to catch the case where we are using an old version of the docker image?
There was a problem hiding this comment.
This is to prevent you from running make run_dropbear but dropbear is not built in the environment. You're right, in the case we are using the old version of the Docker image, or it is somehow missing.
There was a problem hiding this comment.
The current Docker image is not updated to include the dropbear binaries, so copying the program in Makefile would fail all the CI/CD tests in the pipeline if we always try to copy it. Adding the check for existence before copying the binaries would make it pass the CI/CD, unless the Docker image is updated before this PR.
There was a problem hiding this comment.
OK. I'm unsure of how best to handle Dockerfile updates (see #34). But, merging this PR in this "non-working" state (dropbear not enabled yet) and then following with a separate PR to update the docker container seems OK.
|
Documentation added, see 5221132. |
arthurp
left a comment
arthurp
left a comment
There was a problem hiding this comment.
- check on the
-ithing and remove it if possible. - start creating a PR to update the docker container.
Otherwise, LGTM. Go ahead and merge when it's ready (you don't have to wait for the container update PR).
| echo "Dropbear started (PID $!)." | ||
| lsof -p $! | ||
| else | ||
| echo "WARNING: dropbear not found, should not use run_dropbear!!!" |
There was a problem hiding this comment.
OK. I'm unsure of how best to handle Dockerfile updates (see #34). But, merging this PR in this "non-working" state (dropbear not enabled yet) and then following with a separate PR to update the docker container seems OK.
2 participants
Enabled SSH into the Asterinas kernel and SCP command. The
Makefileconfigures arun_dropbeartarget to start the kernel with the dropbear server automatically started. Also,test/Makefilecopies the compiled dropbear programs into the initramfs and generates the host keys,