Skip to content

Rotation Crash on TagSubstitutionBlock #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armele wants to merge 3 commits into
base: version/1.21
Choose a base branch
from
+25 −5
Open

Rotation Crash on TagSubstitutionBlock #814

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c54ee1
Update CapturedBlock.java
armele Jan 22, 2026
42e8ee2
Merge branch 'version/1.21' into rotation_crash
armele Mar 12, 2026
87a03b4
Added logging per code review feedback.
armele Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/main/java/com/ldtteam/structurize/component/CapturedBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.ldtteam.structurize.component;

import com.ldtteam.structurize.api.Log;
import com.ldtteam.structurize.api.RotationMirror;
import com.ldtteam.structurize.blueprints.v1.Blueprint;
import com.mojang.serialization.Codec;
Expand Down Expand Up @@ -67,22 +68,41 @@ public CapturedBlock(final BlockState blockState,
*/
public CapturedBlock applyRotationMirror(final RotationMirror rotationMirror, final Level level)
{
final BlockState rotatedState = rotationMirror.applyToBlockState(blockState);

// No BE data: just rotate the state.
if (serializedBE.isEmpty())
{
return new CapturedBlock(rotationMirror.applyToBlockState(blockState), serializedBE, itemStack);
return new CapturedBlock(rotatedState, serializedBE, itemStack);
}

// If the rotated state does not host a BE, drop any BE tag (prevents renderer/loader issues).
if (!rotatedState.hasBlockEntity())
Copy link
Contributor

@Raycoms Raycoms Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it happen that we get serializedBE not empty but it has no block entity?

Copy link
Author

@armele armele Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I saw when debugging was that for this specific decoration the block entity was reported as "present but blank" - showed up as "{}" when dumping the logs. Not sure how that comes about... but wanted to guard against it.

Copy link
Contributor

@Raycoms Raycoms Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be interesting to log that then

{
Log.getLogger().warn("Block {} is not empty, but has no block entity.", rotatedState);
return new CapturedBlock(rotatedState, Optional.empty(), itemStack);
}

// Rotate/migrate the BE tag using the Blueprint rotation logic
final Blueprint blueprint = new Blueprint((short) 1, (short) 1, (short) 1, level.registryAccess());
blueprint.addBlockState(BlockPos.ZERO, blockState);
blueprint.addBlockState(BlockPos.ZERO, rotatedState);
blueprint.getTileEntities()[0][0][0] = serializedBE.get();
blueprint.setCachePrimaryOffset(BlockPos.ZERO);
blueprint.setRotationMirrorRelative(rotationMirror, level);

return new CapturedBlock(blueprint.getPalette()[blueprint.getPalleteSize()],
Optional.of(blueprint.getTileEntities()[0][0][0]),
itemStack);
final CompoundTag rotatedTag = blueprint.getTileEntities()[0][0][0];
Optional<CompoundTag> beTag = Optional.ofNullable(rotatedTag);

// Drop invalid/empty BE tags.
if (beTag.isEmpty() || beTag.get().isEmpty() || !beTag.get().contains("id"))
{
beTag = Optional.empty();
}

return new CapturedBlock(rotatedState, beTag, itemStack);
}


public boolean hasBlockEntity()
{
return serializedBE.isPresent() && !serializedBE.get().isEmpty();
Expand Down