Reusable module templates#11205
Open
Thodor12 wants to merge 7 commits intoversion/1.21from
Open
Conversation
# Conflicts: # src/main/java/com/minecolonies/core/client/gui/AbstractModuleWindow.java # src/main/java/com/minecolonies/core/client/gui/townhall/WindowTownHallCantCreateColony.java # src/main/java/com/minecolonies/core/client/gui/townhall/WindowTownHallColonyManage.java # src/main/java/com/minecolonies/core/client/gui/townhall/WindowTownHallDeleteAbandonColony.java # src/main/java/com/minecolonies/core/colony/buildings/moduleviews/MinimumStockModuleView.java
# Conflicts: # src/main/java/com/minecolonies/core/client/gui/AbstractBuildingMainWindow.java # src/main/java/com/minecolonies/core/client/gui/AbstractBuildingWindow.java # src/main/java/com/minecolonies/core/client/gui/AbstractModuleWindow.java # src/main/java/com/minecolonies/core/client/gui/WindowClipBoard.java # src/main/java/com/minecolonies/core/client/gui/WindowPostBoxMain.java # src/main/java/com/minecolonies/core/client/gui/modules/ConnectionModuleWindow.java # src/main/java/com/minecolonies/core/client/gui/modules/MinimumStockModuleWindow.java # src/main/java/com/minecolonies/core/client/gui/modules/WindowListRecipes.java # src/main/java/com/minecolonies/core/client/gui/townhall/WindowAlliancePage.java # src/main/java/com/minecolonies/core/client/gui/townhall/WindowPermissionsPage.java # src/main/java/com/minecolonies/core/colony/buildings/moduleviews/BuildingResourcesModuleView.java # src/main/java/com/minecolonies/core/colony/buildings/moduleviews/ColonyConnectionModuleView.java # src/main/java/com/minecolonies/core/colony/buildings/moduleviews/MinimumStockModuleView.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ITemplateModuleImplementation details
ITemplateModuleandITemplateModuleViewgetTemplateStorageId()method, the values that the server and client return must be identical!!IPersistentModule, if not you must implement the (de)serialize methodsresetTemplateAssignment()method on places where the configuration is modified, this is so that if the building is actively tracking a template, upon modification of data it'll automatically untrack the template, meaning that if another module syncs, the changes in this building won't be wiped againgetDescriptionText(CompoundTag data)method, this is to implement a more appropriate description text for the current module, otherwise it'll say "No description" on the second line in the windowTesting
Review please