feat: iaccu#487
Merged
Merged
Conversation
…lways right-nesting
Closed
MackieLoeffel
left a comment
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
Except for one small comment, this PR looks good to me.
Collaborator
|
Thanks, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the
iaccutactic.Addresses #364.
The function
Hyps.buildAccuProofdirectly builds the proof required byiaccufrom aHypsinstance. Since the set of hypotheses is organised as a tree, a simple recursion on aHypsinstance would have resulted in the spatial hypotheses being combined with arbitrary associativity. Instead,Hyps.buildAccuProofAuxensures that the combined proposition is right-nested.Checklist
authorssection of any appropriate files