feat: istart with BI specified#505
Open
alvinylt wants to merge 6 commits into
Open
Conversation
42 tasks
Comment on lines
+119
to
+122
| customProp.forM <| fun customProp => do | ||
| let eq ← isDefEq irisGoal.prop customProp | ||
| if !eq then throwError m!"istart: currently in the Iris Proof Mode with \ | ||
| {irisGoal.prop} rather than {customProp}" |
Collaborator
There was a problem hiding this comment.
Not tested, but I think something like the following would be a bit simpler:
Suggested change
| customProp.forM <| fun customProp => do | |
| let eq ← isDefEq irisGoal.prop customProp | |
| if !eq then throwError m!"istart: currently in the Iris Proof Mode with \ | |
| {irisGoal.prop} rather than {customProp}" | |
| if let some customProp := customProp then | |
| if !(← isDefEq irisGoal.prop customProp) then | |
| throwError m!"istart: currently in the Iris Proof Mode with {irisGoal.prop} rather than {customProp}" |
|
|
||
| customProp.forM <| fun customProp => do | ||
| let eq ← isDefEq prop customProp | ||
| if !eq then throwError "istart: {customProp} is not a valid BI instance type" |
Collaborator
There was a problem hiding this comment.
Can be simplified as above.
| (_ : ⊢@{PROP1} P1) : ⊢@{PROP2} P2 -∗ P2 := by | ||
| iintro P2 | ||
| istart PROP1 | ||
|
|
Collaborator
There was a problem hiding this comment.
The usecase for specifying the type of propositions explicitly is for embeddings. Can you please port this instance and test that it works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
istartso that one can specify the BI instance to be used for entering the Iris Proof Mode.Addresses #239.
Checklist
authorssection of any appropriate files