feat: port bi/lib/core.v#522
Open
alvinylt wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports
bi/lib/core.v.Addresses #279.
The theorems
coreP_entailsandcoreP_entails'are proven in Rocq by rewriting of BI entailments.Meanwhile, I'm using two auxiliary lemmacoreP_entails_auxsincerwin Lean only works with equalities and↔. Possible example to showcase the use ofrw'if we can get the tactic working.The bug in
rw'is fixed (see discussions). By usingrw', we are able to simplify some of the proofs (see relevant commit).Until #1 is resolved, we can perhaps consider whether to implement
Propertype class instances that are ignored in Iris-Lean as theorems with the annotationrw_mono_ruleinstead.Checklist
authorssection of any appropriate files