feat: add support for match in iprop(...)#525
Merged
MackieLoeffel merged 3 commits intoJul 22, 2026
Conversation
This PR adds a macro expansion, such that in `iprop(match ... with ...)` the right-hand-side of each match alternative is wrapped with `iprop` again. For example, this enables the parsing of the following: ```lean4 iprop(match p with | true => P ∗ Q | false => Q ∗ P) ```
alexkeizer
commented
Jul 19, 2026
alexkeizer
commented
Jul 19, 2026
Collaborator
|
Nice. I'm glad that there's a way to do this without writing our own matching primitive. |
MackieLoeffel
left a comment
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
Great, thanks for the PR! I responded to the comments.
Contributor
Author
|
@MackieLoeffel I responded to your comments, could you have another look? |
MackieLoeffel
approved these changes
Jul 22, 2026
MackieLoeffel
left a comment
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
This looks great now, thank you!
Contributor
Author
|
Thanks for the quick reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a macro expansion, such that in
iprop(match ... with ...)the right-hand-side of each match alternative is wrapped withipropagain.For example, this enables the parsing of the following:
Checklist
authorssection of any appropriate filesGenerative AI Guidelines
This code is 100% human-written