feat(*): Log progress messages to stderr even when using json output on stdout#495
Open
eric-wieser wants to merge 1 commit intomasterfrom
Open
feat(*): Log progress messages to stderr even when using json output on stdout#495eric-wieser wants to merge 1 commit intomasterfrom
json output on stdout#495eric-wieser wants to merge 1 commit intomasterfrom
Conversation
Member
|
Does this actually help us with mathlib CI? Does this produce too much output for the CI log? Should it rather print progress messages as JSON, so that we can postprocess them (more easily)? |
Member
Author
What's the easiest way to find out? Can I make a mathlib PR pointing lean to this branch? Edit:
That's probably a good idea, especially if this approach overloads the CI log. It was more work though since I'd need to modify the python script in mathlib too, and I figured this might be good enough. |
eric-wieser
added a commit
to leanprover-community/mathlib3
that referenced
this pull request
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't actually tested this, but it seems plausible that it would work.
Motivated by https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Showing.20progress.20of.20mathlib.20builds/near/214955317