feat(library/init/core): allow lists of proofs#533
Draft
eric-wieser wants to merge 9 commits intomasterfrom
Draft
feat(library/init/core): allow lists of proofs#533eric-wieser wants to merge 9 commits intomasterfrom
eric-wieser wants to merge 9 commits intomasterfrom
Conversation
With upstream changes to mathlib, this would allow `fintype some_prop`, which would in turn allow proofs to be used to index finite things like matrices or summations.
Member
|
IIRC it was intentional that the type parameter of list and option is in Type instead of Sort, as this simplifies type inference. Have you tried compiling mathlib with this change? |
Member
Author
|
I have not at any point tried to build lean itself locally, and was relying on CI to do that. Presumably once this build passes, I can create a mathlib branch that points to this branch, and have CI test that too? |
Member
|
You need to make a tag for the CI to upload a release. Please make the tag on your own fork. |
eric-wieser
commented
Feb 18, 2021
eric-wieser
commented
Feb 18, 2021
Member
Author
|
Build is full of failures with trivial goals that /home/runner/work/lean/lean/library/init/data/list/lemmas.lean:25:3: error: tactic failed, there are unsolved goals
state:
case list.cons
α : Type u,
t_hd : α,
t_tl : list α,
t_ih : t_tl ++ nil = t_tl
⊢ t_hd = t_hd ∧ t_tl = t_tlI guess I'll have to try this locally... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With upstream changes to mathlib, this would allow
fintype some_prop, which would in turn allow proofs to be used to index finite things like matrices or summations.