Skip to content

Update PR guidelines to refer to pull request conventions #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JadAbouHawili wants to merge 2 commits into
base: lean4
Choose a base branch
from
Open

Update PR guidelines to refer to pull request conventions #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af98453
Update PR guidelines to refer to pull request conventions
JadAbouHawili Apr 11, 2026
d3140fa
Update commit conventions to pull request conventions
JadAbouHawili Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/menus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
- Naming conventions: contribute/naming.html
- Code style guideline: contribute/style.html
- Documentation style: contribute/doc.html
- Commit conventions: contribute/commit.html
- Pull Request conventions: contribute/commit.html
- Pull request review guide: contribute/pr-review.html
- Contribution statistics: mathlib_stats.html
- Tags and branches: contribute/tags_and_branches.html
2 changes: 1 addition & 1 deletion templates/contribute/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ Once you're happy with your local changes, it's time to make a pull request.
This helps you get feedback as you go along, and it is much easier to review.
This is especially important for new contributors as it prevents wasted effort.

* The title and description of the PR should follow our [commit conventions](commit.html).
* The title and description of the PR should follow our [pull request conventions](commit.html).

* If you are moving or deleting declarations, please include these lines at the bottom of the commit message
(that is, before the `---`) using the following format:
Expand Down