Conversation
Member
|
Could you elaborate a bit on how these "missions and values" were drafted? Is this the consensus of the maintainer team or is this your personal suggestion? |
We may wish to write about our mission in the future but not here.
3dbf09f to
4d384f9
Compare
Contributor
|
This was discussed in the maintainers stream, received broad support (and some feedback) there and no objections. I wouldn't call this a done decision, though: feedback is still welcome. |
Member
|
The first version contained a "mission statement", which I was (independent of its content) quite surprised by to see without any context. The new version, which only contains the values is much less controversial I think. |
chrisflav
reviewed
May 6, 2026
Member
There was a problem hiding this comment.
I can't make inline comments at the moment because of the github issue, so let me write some thoughts here:
- In the introductory paragraph for "Implications for PR review" I would link to the review guide. Generally, there is quite a bit of overlap here. Maybe you can comment on what the main purpose of this section is? Is it "give a summary of our review process to outsiders, in particular non-formalists"?
- I would put the "Are the definitions correct" paragraph much higher, maybe after "Is the author a human".
- "instance diamonds": It seems to me that the target audience of this text includes non-formalisers. For them, the term "diamond" will not be known. There are also some other technical terms like
set_option maxHeartbeatsetc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.