feat: display reviewer interests and GitHub usernames#841
feat: display reviewer interests and GitHub usernames#841bryangingechen wants to merge 4 commits intolean4from
Conversation
Fetches preferred labels and free-form notes from the queueboard API at build time (via QUEUEBOARD_API_URL repo variable) and displays them on the reviewer team page. Adds github field to People dataclass; people.yaml entries will need github usernames added to map API data to members. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Lets reviewers use links and emphasis in their interests blurb. Also puts the GitHub handle next to the name with inline <code> styling instead of a block <pre>. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Here's what the page looks like at the moment: |
|
For the moment this data is only displayed on the reviewers team page, but we could also show this on e.g. the maintainer team page as well, if people think that's a good idea. |
joneugster
left a comment
joneugster
left a comment
There was a problem hiding this comment.
Thanks for doing this! Not a reviewer in this repo but the PR looks good!
One thing I noticed which hasn't directly anything to do with this PR: Once you're on the "Reviewer" page, the navigation back to the teams overview or to another team (e.g. "Admin") is not great/missing. One could improve the UX of the site by adding some links or other navigational options.
| - Jovan Gerbscheid | ||
| - Sébastien Gouëzel | ||
| - Markus Himmel | ||
| - Julia Markus Himmel |
There was a problem hiding this comment.
Separate PR? (I'd merge right away.)
There was a problem hiding this comment.
I actually did confirm the changes I made in this PR with Julia already. If you insist I can break them out into a separate PR though.
| <li>{{ member.name }}</li> | ||
| <li> | ||
| {{- member.name }} (<code>@{{ member.github }}</code>) | ||
| {%- if reviewer_data is defined and member.github and member.github in reviewer_data -%} |
There was a problem hiding this comment.
Can the webpage say somewhere that the @handles are github usernames?
3 participants
This PR adds reviewer GitHub usernames and interests fields from the queueboard backend to the reviewers team page. The API endpoint URL the data is fetched from is stored as a repo variable
QUEUEBOARD_REVIEWER_INTERESTS_API_URLwhich I've already set up in the repo.Cf. #mathlib reviewers > Topics of interest / competence @ 💬