[Merged by Bors] - chore: move and generalize card_fiber_eq_of_mem_range#10088
Closed
[Merged by Bors] - chore: move and generalize card_fiber_eq_of_mem_range#10088
Conversation
dupuisf
added
awaiting-review
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
Ruben-VandeVelde
changed the title
urkud
reviewed
Feb 11, 2024
urkud
added
awaiting-author
ghost
added
the
merge-conflict
PR summaryImport changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
dupuisf
added
awaiting-review
and removed
awaiting-author
Member
|
Is the PR description accurate? It says "this PR moves..." but I only see a new declaration. Anyway LGTM, thanks! bors d+ |
Contributor
|
✌️ dupuisf can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
Contributor
Author
Indeed I messed up when merging master somehow. Now it's an actual move again. Thanks! |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
This PR moves the lemma `card_fiber_eq_of_mem_range` from `RingTheory/IntegralDomain` to `GroupTheory/Index` which makes far more sense. It also adds the additive version, generalizes to `MonoidHomClass`, and puts it in the `MonoidHom` namespace (instead of root). Co-authored-by: Yury Kudryashov <urkud@urkud.name>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Contributor
|
It seems like you may have forgotten the deprecated alias? |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
This PR adds a deprecation alias that was missing from #10088.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
This PR adds a deprecation alias that was missing from #10088.
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
This PR moves the lemma `card_fiber_eq_of_mem_range` from `RingTheory/IntegralDomain` to `GroupTheory/Index` which makes far more sense. It also adds the additive version, generalizes to `MonoidHomClass`, and puts it in the `MonoidHom` namespace (instead of root). Co-authored-by: Yury Kudryashov <urkud@urkud.name>
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
This PR adds a deprecation alias that was missing from #10088.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the lemma
card_fiber_eq_of_mem_rangefromRingTheory/IntegralDomaintoGroupTheory/Indexwhich makes far more sense. It also adds the additive version, generalizes toMonoidHomClass, and puts it in theMonoidHomnamespace (instead of root).Co-authored-by: Yury Kudryashov urkud@urkud.name