fix: gate reference-manual tagging on release notes title correctness#12512
Merged
fix: gate reference-manual tagging on release notes title correctness#12512
Conversation
This PR fixes a release workflow bug where the reference-manual repository would get tagged with a stale release notes title (e.g., still showing "-rc1" for a stable release). The root cause was a sequencing issue: `release_steps.py` didn't update the release notes title when bumping the reference-manual toolchain, and `release_checklist.py` only checked the title while the bump PR was open. Once merged, it went straight to tagging without rechecking. Two fixes: - `release_checklist.py`: add a title correctness check before tagging reference-manual (blocks tagging if the title is wrong) - `release_steps.py`: automatically update the `#doc` title line in the release notes file when bumping reference-manual (handles both RC-to-stable and RC-to-RC transitions) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
…itle-ordering # Conflicts: # script/release_steps.py
kim-em
added a commit
that referenced
this pull request
Feb 17, 2026
…#12512) This PR fixes a release workflow bug where the reference-manual repository would get tagged with a stale release notes title (e.g., still showing "-rc1" for a stable release). The root cause was a sequencing issue: `release_steps.py` didn't update the release notes title when bumping the reference-manual toolchain, and `release_checklist.py` only checked the title while the bump PR was open. Once merged, it went straight to tagging without rechecking. Two fixes: - `release_checklist.py`: add a title correctness check before tagging reference-manual (blocks tagging if the title is wrong) - `release_steps.py`: automatically update the `#doc` title line in the release notes file when bumping reference-manual (handles both RC-to-stable and RC-to-RC transitions) 🤖 Prepared with Claude Code Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a release workflow bug where the reference-manual repository would get tagged with a stale release notes title (e.g., still showing "-rc1" for a stable release).
The root cause was a sequencing issue:
release_steps.pydidn't update the release notes title when bumping the reference-manual toolchain, andrelease_checklist.pyonly checked the title while the bump PR was open. Once merged, it went straight to tagging without rechecking.Two fixes:
release_checklist.py: add a title correctness check before tagging reference-manual (blocks tagging if the title is wrong)release_steps.py: automatically update the#doctitle line in the release notes file when bumping reference-manual (handles both RC-to-stable and RC-to-RC transitions)🤖 Prepared with Claude Code