feat: support code actions in linters#14402
Open
wkrozowski wants to merge 18 commits into
Open
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
wkrozowski
marked this pull request as ready for review
July 16, 2026 14:04
Contributor
Author
|
!bench |
|
Benchmark results for 3543a67 against 46cf2b9 are in. There are significant results. @wkrozowski
Large changes (1✅)
Small changes (1✅, 8🟥)
|
wkrozowski
force-pushed
the
wojciech/lintersCodeActions
branch
from
July 16, 2026 14:27
3543a67 to
ed65cc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the support for code actions to linters. When
Elab.asyncis enabled, before a linter task is dispatched, we create a promise for the info tree node. Then, we accumulate newly added info trees through the linter execution and we resolve the promise inside of the linter task. Finally, on the main task, we modify the info tree (wrapped in command context) and add a new leaf, with an mvar id, that will eventually be filled with a promise value.This PR also supports code actions in stateful linters (#14357), but does not offer such support for module linters, that fire at terminal commands and code actions from there do not surface to the info view.
Related to RFC #4363.