chore: make file_not_found test more robust#14461
Closed
TwoFX wants to merge 1 commit into
Closed
Conversation
TwoFX
added
changelog-no
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
eric-wieser
reviewed
Jul 21, 2026
Comment on lines
+19
to
+21
| /-- error: no such file or directory -/ | ||
| #guard_msgs (substring := true) in | ||
| #eval (discard $ IO.FS.Handle.mk nonexistent_file Mode.read : IO Unit) |
Contributor
There was a problem hiding this comment.
This should presumably use some kind of assertThrows helper that verifies the right IO.Error constructor is raised, and not just its string representation?
Member
Author
|
Closing in favor of #14479. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
file_not_foundtest work on Windows after #14423.