Skip to content

Conversation

@sharma-anushka
Copy link

Description

This PR fixes an issue where the Add / Remove admin privileges dialog did not open upon clicking the Add admin privileges action inside the Users tab.

What was changed

  • Adjusted click handling so the menu interaction no longer blocks dialog rendering

  • Preserved existing behavior and API of UserActionsDropdown and UserPrivilegeModal

Why this works

The dialog state is now set at the correct time in Vue’s render cycle

Prevents the menu component from swallowing or cancelling the dialog trigger

Matches the expected UX: clicking the Add admin privilages reliably opens the confirmation dialog

Testing

Manually verified:

  • Add admin privileges dialog opens correctly
  • Remove admin privileges dialog opens correctly
    Email / Deactivate / Delete actions still behave as expected
Screen.Recording.2026-01-20.at.11.23.35.PM.mov

Related issue

Fixes #5645

@learning-equality-bot
Copy link

👋 Thanks for contributing!

We will assign a reviewer within the next two weeks. In the meantime, please ensure that:

  • You ran pre-commit locally
  • All issue requirements are satisfied
  • The contribution is aligned with our Contributing guidelines. Pay extra attention to Using generative AI. Pull requests that don't follow the guidelines will be closed.

We'll be in touch! 😊

@MisRob
Copy link
Member

MisRob commented Jan 21, 2026

Hi again @sharma-anushka, thank you. Before we assign a maintainer, I will first invite the community review.

@MisRob
Copy link
Member

MisRob commented Jan 21, 2026

📢 ✨ Community Review guidance for both authors and reviewers.

@MisRob
Copy link
Member

MisRob commented Jan 21, 2026

Hi @LightCreator1007 - I think you mentioned interest to collaborate on this issue - you're welcome to review. Thanks both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some administration channel and user actions are non-functional

2 participants