POC: support ledger derivation paths#2006
Conversation
|
Leather Web build 55a24ec — Web preview, Web test report |
|
Leather Extension build 5fa897c — Extension build, Extension test report, Storybook, Chromatic |
kyranjamie
force-pushed
the
feat/ledger-derivation-path-compatiblility
branch
from
55a24ec to
5fa897c
Compare
|
i'd suggest we only pull either ledger path keys or leather path keys, by asking users in the beginning of the setup. IMO that would simplify unexpected scenarios like connected dApps |
Mmm, yeah this would make it a one-time thing rather than something configurable |
|
@kyranjamie @edgarkhanzadian What do you think of this solution? This would only be visible for Ledger user's The idea is to have two educational callouts: one for Ledger users and one for Stacks users. Each callout would link to Account derivation path in Settings, where users can choose between Stacks (the protocol default) and Ledger. For confirmation, we could show a toaster after selection, though the selected state alone might be sufficient. In the Setting's page, there could be an entry point as well, called "Account derivation path" to allow users to access the page, instead of only via the call out. As for the article: we can redirect them to this one: https://app.leather.io/support/guide/why-your-ledger-account-might-not-show-up-in-leather |
|
Added to the designs:
Please take a look and let me know your thoughts 🙂 Designs here: https://www.figma.com/design/VQPOPkkrfVcf0BEd9kz3HZ/%F0%9F%A6%BE-Ledger--Onboarding---Transaction-signing-2024?node-id=3327-5992 ( |
|
After today's discussion we landed on supporting this from the onboarding create wallet flow as an initial choice. We'll add a section to the account screen as well informing users how to switch between the options by restoring their wallets. |
|
Final Designs here:
|
kyranjamie
changed the title
5 participants
Following the conversation with King yesterday on Slack, @mica000's proposed callout to explain the situation to users , and the several other occasions of this limitation being noted as a pretty damning blocker, I've POCd the base functionality we need to toggle between classic Stacks derivation paths and the Ledger ones.
cc/ @fabric-8 @mica000 would like to jam on how we can integrate this. Inclined to suggest we have a toggle within the settings menu. Only visible when Ledger connected. For new users, we'll always pull both keys. For existing users, we'll have to prompt the user to add the keys with the modal connection flow. I think I would not try to advertise this feature too much. It's there if needed, and for users that explore settings, but think I would not highlight too much.
There are some annoying consequences to this allowing this toggle. For example, users already connected to dApps, that then change to Ledger addresses. Future RPC requests will use the Ledger path keys but expect Stacks path keys. I suggest we also clear existing sign-ins when toggling (so we should also communicate that). I think this should have it's own page within settings. It is not something users should do regularly, so intentional friction is a good idea.
2026-01-15-000611.mp4