fix(leav/ui): record form create skip link/tree element errors before first submit - #992
Open
sberthier wants to merge 1 commit into
Open
fix(leav/ui): record form create skip link/tree element errors before first submit#992sberthier wants to merge 1 commit into
sberthier wants to merge 1 commit into
Conversation
| if (skipCheckElementErrors) { | ||
| // once submitted at least one time, show eventual fields errors | ||
| setSkipCheckElementErrors(false); | ||
| } |
Collaborator
There was a problem hiding this comment.
On met une rustine ici.
Pourquoi pas mais quelle est la raison de la soumission du formulaire au chargement de celui-ci ?
Collaborator
Author
There was a problem hiding this comment.
J'ai pas de meilleur solution à mon niveau de connaissance des formulaire natif/antd/design-system/leav-ui. Peut-être y a t'il mieux à faire ?
Collaborator
There was a problem hiding this comment.
Je regarde aujourd'hui.
Collaborator
There was a problem hiding this comment.
Qu'en penses tu ?
| onFinish={() => | ||
| onFinish={() => { | ||
| if (skipCheckElementErrors) { | ||
| // once submitted at least one time, show eventual fields errors |
Collaborator
There was a problem hiding this comment.
Le commentaire explique ce que tu fais mais pas pourquoi.
Je te propose :
- Aucun commentaire et l'intégrer dans le nommage (variable :
avoidFormValidationOnLoadpar ex) => Ma solution favorite : on se passe du commentaire. - 1 meilleur commentaire : "Creation form submits on load, we avoid the first validation with this skip"
before first submit only
sberthier
force-pushed
the
fix/leav/ui/form-create-skip-link-tree-element-errors
branch
from
July 21, 2025 12:14
3f927c4 to
5e5ab8c
Compare
NicoSourimant
approved these changes
Jul 21, 2025
jrmyb
approved these changes
Jul 21, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Definition Of Review
Definition Of Mergeable