Skip to content

feat(rebranding): add segmented control component#1821

Draft
soulcramer wants to merge 4 commits intomainfrom
rebranding-segmeneted-button
Draft

feat(rebranding): add segmented control component#1821
soulcramer wants to merge 4 commits intomainfrom
rebranding-segmeneted-button

Conversation

@soulcramer
Copy link
Copy Markdown
Collaborator

@soulcramer soulcramer commented Jan 22, 2026

📋 Changes

🤔 Context

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.

📸 Screenshots

🗒️ Other info

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: checks
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 9.2.1 ✅ Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 9.2.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: dokka
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dokkaHtmlMultiModule 9.2.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android globalCiUnitTest verifyPaparazziRelease 9.2.1 ❌ Build Scan not published

github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 22, 2026
View reviewed changes
Comment thread spark/src/main/kotlin/com/adevinta/spark/components/segmentedcontrol/SegmentedControl.kt
*/
@Composable
private fun SegmentedControlContent(
segments: List<SegmentData>,

Check failure

Code scanning / Android Lint

Immutable collections should ideally be used in Composables

The Compose Compiler cannot infer the stability of a parameter if a List<SegmentData> is used in it, even if the item type is stable. You should use Kotlinx Immutable Collections instead: segments: ImmutableList<SegmentData> or create an @Immutable wrapper for this class: @Immutable data class SegmentsList(val items: List<SegmentData>) See https://slackhq.github.io/compose-lints/rules/#avoid-using-unstable-collections for more information.
Comment thread spark/src/main/kotlin/com/adevinta/spark/components/segmentedcontrol/SegmentedControl.kt
role: Role,
enabled: Boolean,
isHorizontal: Boolean,
segmentContents: List<@Composable () -> Unit>,

Check failure

Code scanning / Android Lint

Immutable collections should ideally be used in Composables

The Compose Compiler cannot infer the stability of a parameter if a List<@Composable () -> Unit> is used in it, even if the item type is stable. You should use Kotlinx Immutable Collections instead: segmentContents: ImmutableList<@Composable () -> Unit> or create an @Immutable wrapper for this class: @Immutable data class SegmentContentsList(val items: List<@Composable () -> Unit>) See https://slackhq.github.io/compose-lints/rules/#avoid-using-unstable-collections for more information.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android
:spark:lintRelease :spark-screenshot-testing:lintRelease :c…
 9.2.1 ❌ Build Scan not published

@soulcramer soulcramer changed the title feat(fileupload): add file upload components and functionality feat(rebranding): add segmented control component Jan 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: checks
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 9.2.1 ✅ Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 9.2.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: dokka
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dokkaHtmlMultiModule 9.2.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android globalCiUnitTest verifyPaparazziRelease 9.2.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Job Summary for Gradle

🏭 CI :: lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android
:spark:lintRelease :spark-screenshot-testing:lintRelease :c…
 9.2.1 ❌ Build Scan not published

@soulcramer soulcramer force-pushed the rebranding-segmeneted-button branch from 6931cc0 to 0e224e4 Compare January 28, 2026 14:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2026

Job Summary for Gradle

🏭 CI :: checks
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 9.2.1 ✅ Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 9.2.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2026

Job Summary for Gradle

🏭 CI :: test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android globalCiUnitTest verifyPaparazziRelease 9.2.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2026

Job Summary for Gradle

🏭 CI :: lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android
:spark:lintRelease :spark-screenshot-testing:lintRelease :c…
 9.2.1 ❌ Build Scan not published

soulcramer and others added 4 commits April 23, 2026 10:55
@soulcramer
feat(segment-button): expose SegmentedButton component as Experimenta…
46ed2ac 
…l for testing

Signed-off-by: Scott Rayapoullé <scott.rayapoulle@adevinta.com>
@soulcramer
feat(rebranding): add segmented control component
72dba60 
Signed-off-by: Scott Rayapoullé <scott.rayapoulle.ext@adevinta.com>
@soulcramer
Adjust the colors and shape of segmented control
dc5ddb4 
Signed-off-by: Scott Rayapoullé <scott.rayapoulle.ext@adevinta.com>
@soulcramer
Refactor SegmentedControl API to use single SingleSelect variant
ed5f151
@soulcramer soulcramer force-pushed the rebranding-segmeneted-button branch from 0e224e4 to ed5f151 Compare April 29, 2026 08:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Job Summary for Gradle

🏭 CI :: checks
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 9.4.1 ✅ Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 9.4.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Job Summary for Gradle

🏭 CI :: build
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease jvmJar 9.4.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Job Summary for Gradle

🏭 CI :: lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android
:spark:lintRelease :spark-screenshot-testing:lintRelease :c…
 9.4.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Job Summary for Gradle

🏭 CI :: test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android globalCiUnitTest verifyPaparazziRelease 9.4.1 ❌ Build Scan not published

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Job Summary for Gradle

🏭 CI :: dokka
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dokkaGeneratePublicationHtml publishToMavenLocal 9.4.1 ❌ Build Scan not published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonMarquis SimonMarquis Awaiting requested review from SimonMarquis SimonMarquis will be requested when the pull request is marked ready for review SimonMarquis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@soulcramer soulcramer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soulcramer @github-advanced-security