[19.0][FIX] base: rename user.groups_id references in domain/code

[dnplkndll]

Context

This is an internal fork PR for testing before submitting upstream to OCA/OpenUpgrade. See OCA/OpenUpgrade#5363 for the 19.0 migration umbrella.

Problem

rename_fields() (from openupgradelib) renames the column on res_users and quoted occurrences in ir.filters.domain, but it does NOT process:

• ir.rule.domain_force — not touched at all
• Unquoted dotted references like user.groups_id.ids that appear inside Python-evaluated domain expressions / server-action code

Concretely, an ir.rule such as:

domain_force = "[('groups_id', 'in', user.groups_id.ids)]"

has its LHS migrated to 'group_ids' but the RHS is left untouched. After migration, any view that triggers the rule crashes at runtime with:

AttributeError: 'res.users' object has no attribute 'groups_id'

(groups_id was renamed to group_ids in Odoo 19; Odoo core then promotes user.group_ids to user.all_group_ids for the implied-groups check, but the source groups_id reference has to be rewritten first.)

Fix

Add a post-step in base/19.0.1.3/pre-migration.py that does a word-boundary regex replace of user.groups_id → user.group_ids in:

• ir_rule.domain_force
• ir_filters.domain
• ir_act_server.code

How tested

Migrated a real Ledo Enterprises prod 18.0 backup (168 installed modules) to 19.0:

1. Without the fix — login page returned HTTP 500: AttributeError("'res.users' object has no attribute 'groups_id'") while evaluating "['|', ('group_ids', '=', False), ('group_ids', 'in', user.groups_id.ids)]". The offending record was ir.rule#345 "Website menu: group_ids".

2. With the fix — re-restored prod backup, manually set ir.rule#345.domain_force back to the broken user.groups_id form to simulate a stock-restore scenario, then ran the migration. The pre-migration's regex_replace fired (visible in logs), the ir.rule was rewritten to user.group_ids, and Odoo core then upgraded it further to the canonical user.all_group_ids.

3. Migration also exercised: ir_filters and ir_act_server queries; no false matches in the test corpus.

Test plan

• Migration completes without AttributeError on res.users.groups_id
• ir.rule.domain_force containing user.groups_id.ids is rewritten
• Login page renders (HTTP 200) after migration
• Promote to OCA/OpenUpgrade once additional review here is done

Branch: 19.0-fix-user-groups-id-rename
Tracking lab: ledoent/openupgrade-lab — scripts/restore-prod.sh carries an SQL fallback for unpatched OpenUpgrade copies.