Add Custom Scheduler#694
Merged
Merged
Conversation
idostyle
reviewed
May 27, 2025
|
|
||
| std::vector<float> sigmas = sd_ctx->sd->denoiser->get_sigmas(sample_steps); | ||
| std::vector<float> sigmas_for_generation; | ||
| if (custom_sigmas_count > 0 && custom_sigmas != nullptr) { |
Contributor
There was a problem hiding this comment.
Could extract this block into a method and share it between txt2img, img2img and img2vid. txt2img seems to have additional logging the other two are missing.
Contributor
Author
There was a problem hiding this comment.
@idostyle thanks for the review. I’ve extracted the sigma preparation into a shared helper, you're right, it's better for maintainability
Contributor
Owner
|
Thank you for your contribution. |
Contributor
|
... shouldnt this sampler technically be called "discrete" ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/BlakeOne/ComfyUI-CustomScheduler
This PR adds a custom scheduler that allows users to manually specify the sigma values for each step.
This is especially useful for debugging when integrating new models that don't work with existing schedulers, or for inference with distilled models such as SID, SIDA or SwD
The number of sigma values must match the number of steps. If n_sigmas < steps, the missing values will currently be filled with zeros. I'm considering whether to keep this behavior or instead repeat the last sigma value to fill the vector.
Example command:
./build/bin/sd -m SiDA_SD15_4.54.54.5_1_lsd100_lsggan0.001_NoEMA_SNR_025634_checkpoint.safetensors -v -p "A photograph of a cat in winter wonderland. 8k resolution" --cfg-scale 1 --steps 1 --sigmas "2.5" --seed 2025For multi-steps, use for example
--sigmas "sigma_0,sigma_1,sigma_2,sigma_3....."I've uploaded a SiDA model checkpoint if someone want to test : SIDA 1.5