Skip to content

refactor: simplify the model loading logic#933

Merged
leejet merged 4 commits into
masterfrom
refactor_preprocess_tensor
Nov 3, 2025
Merged

refactor: simplify the model loading logic#933
leejet merged 4 commits into
masterfrom
refactor_preprocess_tensor

Conversation

@leejet

@leejet leejet commented Nov 2, 2025

Copy link
Copy Markdown
Owner

No description provided.

@leejet leejet merged commit 8f6c5c2 into master Nov 3, 2025
9 checks passed
@Green-Sky

Green-Sky commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

This breaks SDXL loading for me.

[ERROR] model.cpp:2186 - tensor 'model.diffusion_model.input_blocks.4.1.proj_in.weight' has wrong shape in model file: got [1, 1, 640, 640], expected [640, 640, 1, 1]
[WARN ] model.cpp:2008 - process tensor failed: 'model.diffusion_model.input_blocks.4.1.proj_in.weight'

Will check more models in a bit.

update: Same with SD2:

[INFO ] model.cpp:2177 - unknown tensor 'cond_stage_model.transformer.text_model.text_projection | q8_0 | 2 [1024, 1024, 1, 1, 1]' in model file
[ERROR] model.cpp:2186 - tensor 'model.diffusion_model.input_blocks.1.1.proj_in.weight' has wrong shape in model file: got [1, 1, 320, 320], expected [320, 320, 1, 1]
[WARN ] model.cpp:2008 - process tensor failed: 'model.diffusion_model.input_blocks.1.1.proj_in.weight'

update2: reconverting that XL model works, but loras fail to apply:

[DEBUG] lora.hpp:175  - lora type: ".lora_down"/".lora_up"
[DEBUG] lora.hpp:177  - finished loaded lora
[WARN ] lora.hpp:860  - unused lora tensor |lora.cond_stage_model_1_transformer_text_model_encoder_layers_0_self_attn_k_proj.alpha|
 (f32): shape(1, 1, 1, 1)
[WARN ] lora.hpp:860  - unused lora tensor |lora.cond_stage_model_1_transformer_text_model_encoder_layers_0_self_attn_k_proj.lora_down.weight|
 (f32): shape(1280, 32, 1, 1)
[WARN ] lora.hpp:860  - unused lora tensor |lora.cond_stage_model_1_transformer_text_model_encoder_layers_0_self_attn_k_proj.lora_up.weight|
 (f32): shape(32, 1280, 1, 1)
[WARN ] lora.hpp:860  - unused lora tensor |lora.cond_stage_model_1_transformer_text_model_encoder_layers_0_self_attn_q_proj.alpha|
...

@leejet

leejet commented Nov 7, 2025

Copy link
Copy Markdown
Owner Author

Which lora model are you using that has caused the problem?

@leejet

leejet commented Nov 7, 2025

Copy link
Copy Markdown
Owner Author

@Green-Sky #951 This PR should fix the compatibility issues with old models.

@Green-Sky

Copy link
Copy Markdown
Contributor

That pr did indeed fix it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants