Conversation
Member
|
Do you want me to code review the service worker stuff? (ie. for learning and feedback). Otherwise I've got a drop in solution for SW which works pretty reliably. |
Member
Author
|
If you have the time to do a code review it would be awesome! But I am also curious to see your solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things left to do or to check:
public/sw.jsthere is to define the list of files we want to be stored by default. I already added the functionality that any other additional file downloaded later is also added to the cacheDON'T RELEASE IT before publishing the whole proper speakers list!!