Will/fix/ros2 graph msf cmake#36
Open
nubertj wants to merge 101 commits into
Open
Conversation
…mb_estimator_graph_ros2
…stency across files
…nventions, including updated includes, parameter handling, and subscription methods. Transition from ros::NodeHandle to rclcpp::Node and adjust message types accordingly for improved compatibility with ROS 2 architecture.
…ies for improved maintainability.
…icTransforms and simplify initialization with only the node pointer.
…raph and smb_estimator_graph_replay, enhancing maintainability and aligning with ROS 2 conventions.
…eading and writing bags, improving performance and compatibility with ROS 2 conventions.
…_in_folder.py, adding support for covariance data and improving error handling.
…y points for console scripts. Introduce new resource file for graph_msf_ros2.
…essing and logging.
…ings for Cholesky factorization and marginals computation, while commenting out the center reference frames parameter.
…tup and readParams functions
…arameters under ros__parameters section
…parameters and node execution
Contributor
Author
|
@willat343 somehow your change to make the cmake work for ros2 seemed to get lost in the history. Can you cherrypick that commit and make a fresh MR against main? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old MR from Will, but now against main: #22 (comment)