Skip to content

fix: consolidate drawer bottom safe-area padding #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
conversun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: consolidate drawer bottom safe-area padding #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/BottomPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ export const BottomPanel = memo(function BottomPanel({ directory }: BottomPanelP
maxSize={layout.bottomPanel.maxHeight}
onSizeChange={h => layoutStore.setBottomPanelHeight(h)}
onClose={() => layoutStore.closeBottomPanel()}
className="pb-[var(--safe-area-inset-bottom)]"
>
<PanelContainer
position="bottom"
Expand Down
1 change: 0 additions & 1 deletion src/components/RightPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ export const RightPanel = memo(function RightPanel({ directory, sessionId }: Rig
maxSize={layout.rightPanel.resizeMaxWidth}
onSizeChange={w => layoutStore.setRightPanelWidth(w)}
onClose={() => layoutStore.closeRightPanel()}
className="pb-[var(--safe-area-inset-bottom)]"
>
<PanelContainer
position="right"
Expand Down
6 changes: 2 additions & 4 deletions src/components/ui/ResizablePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export const ResizablePanel = memo(function ResizablePanel({
const { preferTouchUi, hasCoarsePointer, hasTouch } = useInputCapabilities()
const touchCapable = preferTouchUi || hasCoarsePointer || hasTouch
const [isResizing, setIsResizing] = useState(false)
const safeBottomInset = 'var(--safe-area-inset-bottom, 0px)'
const panelRef = useRef<HTMLDivElement>(null)
const contentRef = useRef<HTMLDivElement>(null)
const rafRef = useRef<number>(0)
Expand Down Expand Up @@ -208,7 +207,6 @@ export const ResizablePanel = memo(function ResizablePanel({
? ({
top: 'calc(var(--safe-area-inset-top, 0px) + var(--desktop-titlebar-height, 0px))',
height: 'calc(100% - var(--safe-area-inset-top, 0px) - var(--desktop-titlebar-height, 0px))',
paddingBottom: safeBottomInset,
} as React.CSSProperties)
: ({} as React.CSSProperties)

Expand Down Expand Up @@ -242,7 +240,7 @@ export const ResizablePanel = memo(function ResizablePanel({
</div>
)}

<div ref={contentRef} className="flex-1 flex flex-col min-h-0 min-w-0 w-full h-full relative bg-bg-100">
<div ref={contentRef} className="flex-1 flex flex-col min-h-0 min-w-0 w-full h-full relative bg-bg-100 pb-[var(--safe-area-inset-bottom)]">
{children}
</div>
</div>
Expand Down Expand Up @@ -293,7 +291,7 @@ export const ResizablePanel = memo(function ResizablePanel({

{isResizing && <div className="absolute inset-0 z-40 bg-transparent pointer-events-auto" />}

<div ref={contentRef} className="absolute inset-0 flex flex-col min-h-0 min-w-0 w-full h-full">
<div ref={contentRef} className="absolute inset-0 flex flex-col min-h-0 min-w-0 w-full h-full pb-[var(--safe-area-inset-bottom)]">
{children}
</div>
</div>
Expand Down