Skip to content

Make splitting submodules private #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdekstrand merged 5 commits into from
Apr 7, 2026
Merged

Make splitting submodules private #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cae0621
splitting: make holdout private
mdekstrand Apr 7, 2026
0f03e80
splitting: make records private
mdekstrand Apr 7, 2026
65a2b6c
splitting: make split private
mdekstrand Apr 7, 2026
e0c192a
splitting: make temporal private
mdekstrand Apr 7, 2026
8b95fc9
splitting: make users private
mdekstrand Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/lenskit/splitting/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@

from lenskit.data import Dataset

from .holdout import HoldoutMethod, LastFrac, LastN, SampleFrac, SampleN
from .records import crossfold_records, sample_records
from .split import TTSplit
from .temporal import split_global_time, split_temporal_fraction
from .users import crossfold_users, sample_users
from ._holdout import HoldoutMethod, LastFrac, LastN, SampleFrac, SampleN
from ._records import crossfold_records, sample_records
from ._split import TTSplit
from ._temporal import split_global_time, split_temporal_fraction
from ._users import crossfold_users, sample_users

__all__ = [
"TTSplit",
Expand Down
0 src/lenskit/splitting/holdout.py → src/lenskit/splitting/_holdout.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/lenskit/splitting/records.py → src/lenskit/splitting/_records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from lenskit.data import Dataset, DatasetBuilder, ItemListCollection, UserIDKey
from lenskit.random import RNGInput, random_generator

from .split import TTSplit
from ._split import TTSplit

_log = logging.getLogger(__name__)

Expand Down
0 src/lenskit/splitting/split.py → src/lenskit/splitting/_split.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/lenskit/splitting/temporal.py → src/lenskit/splitting/_temporal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from lenskit.data import Dataset, DatasetBuilder, ItemListCollection
from lenskit.logging import get_logger

from .split import TTSplit
from ._split import TTSplit

_log = get_logger(__name__)

Expand Down
4 changes: 2 additions & 2 deletions src/lenskit/splitting/users.py → src/lenskit/splitting/_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
from lenskit.logging import item_progress
from lenskit.random import RNGInput, random_generator

from .holdout import HoldoutMethod
from .split import TTSplit
from ._holdout import HoldoutMethod
from ._split import TTSplit

_log = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion src/lenskit/tuning/_iterative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from lenskit.pipeline.components import Placeholder
from lenskit.pipeline.nodes import ComponentConstructorNode, ComponentInstanceNode
from lenskit.random import make_seed
from lenskit.splitting.split import TTSplit
from lenskit.splitting import TTSplit
from lenskit.state import ParameterContainer
from lenskit.training import ModelTrainer, TrainingOptions, UsesTrainer

Expand Down
2 changes: 1 addition & 1 deletion tests/batch/test_pipeline_profiling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from lenskit.basic import BiasScorer
from lenskit.batch import BatchPipelineRunner
from lenskit.pipeline import PipelineProfiler, topn_pipeline
from lenskit.splitting.split import TTSplit
from lenskit.splitting import TTSplit

from .test_batch_pipeline import MLB, ml_split, mlb

Expand Down
2 changes: 1 addition & 1 deletion tests/splitting/test_split_holdout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import pytest

from lenskit.data import Dataset
from lenskit.splitting.holdout import LastFrac, LastN, SampleFrac, SampleN
from lenskit.splitting import LastFrac, LastN, SampleFrac, SampleN


def test_sample_n(ml_ds: Dataset):
Expand Down
2 changes: 1 addition & 1 deletion tests/splitting/test_split_records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import pytest

from lenskit.data import Dataset
from lenskit.splitting.records import crossfold_records, sample_records
from lenskit.splitting._records import crossfold_records, sample_records


def test_crossfold_records(ml_ds: Dataset):
Expand Down
3 changes: 1 addition & 2 deletions tests/splitting/test_split_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
import pytest

from lenskit.data import Dataset, from_interactions_df
from lenskit.splitting.holdout import SampleFrac, SampleN
from lenskit.splitting.users import crossfold_users, sample_users
from lenskit.splitting import SampleFrac, SampleN, crossfold_users, sample_users


def test_crossfold_users(ml_ds: Dataset):
Expand Down
Loading