Skip to content

Rename logging modules to be private#1070

Merged
mdekstrand merged 3 commits intolenskit:mainfrom
mdekstrand:tweak/logging-modules
Apr 13, 2026
Merged

Rename logging modules to be private#1070
mdekstrand merged 3 commits intolenskit:mainfrom
mdekstrand:tweak/logging-modules

Conversation

@mdekstrand
Copy link
Copy Markdown
Member

This makes the logging submodules private, which is the last set of private submodules. Closes #947.

@mdekstrand mdekstrand added this to the 2026.1 milestone Apr 10, 2026
@mdekstrand mdekstrand added internals Internal infrastructure (parallelism, math, etc.) breaking labels Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (992c791) to head (ea71939).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/lenskit/logging/tasks.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   89.46%   89.48%   +0.02%     
==========================================
  Files         233      231       -2     
  Lines       15874    15867       -7     
==========================================
- Hits        14201    14199       -2     
+ Misses       1673     1668       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand mdekstrand merged commit ea71939 into lenskit:main Apr 13, 2026
42 of 48 checks passed
@mdekstrand mdekstrand deleted the tweak/logging-modules branch April 13, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking internals Internal infrastructure (parallelism, math, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make internal modules private

1 participant