Fixture additions#307
Merged
leonardt merged 79 commits intoleonardt:fixture_additionsfrom Aug 13, 2021
Merged
Conversation
Fix indexing into one bit of a spice bus
…ssue with verilog reads
…ill need to fix tests, but will wait until after merge
…m about to make minor changes to background poke class
…itrary args to run()
…ght now it will likely crash if a var is background-poked and work incorrectly if a poke to a var is used to override an existing background poke.
…rent output is next
…nually add delays between poke and expect.
Owner
|
Sorry for letting this linger so long, I'd like to help get this integrated ASAP so we can avoid merge pains. Do you have access to the fault repo as a collaborator? I think the first step will be to merge this into a branch in this repo (rather than your fork) and reopening the PR from the internal branch so that CI will run properly (CI is failing because it doesn't work with forks) |
Owner
|
Actually it looks like you are collaborator, let me know if you have issues with access, I'm going to merge this into a local branch and open a new PR. |
Owner
|
Ok let's work off this one now: #312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two additions:
I decided to move a third improvement, mLingua support, to another PR because right now only Poke works, and not Expect or GetValue.