You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is the cache issue at the magma/python level compile? Or the verilator test?
Sorry I should have provided more detail. If I add FixedProtocol to the list of BoxT I get an attribute error about BrokenProtocol having no debug_name in the FixedProtocol cases (this is the error I get in the BrokenProtocol cases). If I run only FixedProtocol it has no errors. If I set BoxT = [FixedProtocol, BrokenProtocol] I get no errors. So some sort of Python level caching issue.
I think a broader fix for this issue is to have fault unpack protocol values at the entrypoint to any fault code (i.e. the fault internals just operate on the underlying magma values). I added the required unpacking for these tests, but I suspect there are (many) other places we may need to the get_magma_value logic. However, this is likely much simpler to do at the API boundary rather than finding all the places internally where we need to call get_magma_value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #327