fix(deps): take the patched postcss and dompurify - #1206
Merged
Conversation
postcss carries a path traversal in its previous-source-map auto loading, where a sourceMappingURL can reach an arbitrary .map file, and it is pulled in by both the dashboard's build and the docs site. dompurify allows a custom element to bypass afterSanitizeElements, and reaches the dashboard through the Monaco editor the tinker and config editors use. Both were already permitted by the declared ranges, so only the lockfiles move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1205
postcss moves to 8.5.24 in both the dashboard and the docs site, clearing the path traversal in its previous-source-map auto loading. dompurify moves to 3.4.12 in the dashboard, clearing the custom element bypass of
afterSanitizeElements, which reaches us through the Monaco editor behind the tinker and config editors.Both versions were already inside the ranges
package.jsondeclares, so nothing but the two lockfiles changes.npm auditreports no vulnerabilities in either workspace afterwards.Worth one note on the verification. The dashboard suite failed 18 tests on the first run after the update, which looked like dompurify changing sanitisation. It was not: the machine was at a load average of 163 and every failure was a 32 second timeout. On a settled machine the same suite passes 982 of 982 in ten seconds. The docs site builds and the Go gate is unchanged.