Fix initial storage file creation error#109
Open
a-h-mzd wants to merge 2 commits intolesnitsky:masterfrom
Open
Fix initial storage file creation error#109a-h-mzd wants to merge 2 commits intolesnitsky:masterfrom
a-h-mzd wants to merge 2 commits intolesnitsky:masterfrom
Conversation
Owner
|
not sure what exactly does this fix. could you provide a reproduction of the issue you're facing and trying to fix with this? |
Author
|
@lesnitsky Without this fix, the try-catch clause on line 22 will fail (since the file is initially empty), resulting in writing to |
|
@lesnitsky I am also running into this problem, looks like this PR fixes the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.