fix(ci): restore memory CODEOWNERS coverage - #3595
Open
GautamSharma99 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3585.
The memory filesystem and git implementation entries in
.github/CODEOWNERSstill referenced pre-rename camelCase filenames. GitHub silently ignored those unmatched paths, so changes to durable memory storage could bypass the intended@letta-ai/system-prompt-ownersreview request.This PR restores the ownership rules and adds a repository check that catches stale literal CODEOWNERS paths after future moves or renames.
Ownership changes
Replaced the stale entries with the current implementation paths:
/src/agent/memory-filesystem.ts/src/agent/memory-git.tsAlso added the deliberately scoped rule:
/src/agent/memory-git-*.tsThat rule covers the extracted git implementation modules currently owned with the core implementation:
memory-git-config-lock.tsmemory-git-hooks.tsmemory-git-signing.tsIt does not sweep in dot-named tests such as
memory-git.auth.test.tsormemory-git.retry.test.ts.Regression prevention
Added
scripts/check-codeowners-paths.jsand wired it intobun run checkas the newCODEOWNERS pathsgate.The validator:
*and?glob rules instead of incorrectly requiring them to name one literal path;existsSync(), so case mistakes fail even on case-insensitive macOS filesystems;.gitandnode_moduleswhile walking the tree;.github/CODEOWNERS:<line>: <pattern> does not exist.Bracket ranges are intentionally not classified as valid CODEOWNERS globs because GitHub CODEOWNERS does not support that gitignore feature.
Tests
Added five Node test-runner cases covering:
The package-level
check:codeownerscommand runs both the validator tests and validation of the real.github/CODEOWNERSfile.Validation completed:
bun run check:codeowners— 5 passed, 0 failed; 11 literal paths checked and 1 glob skippedbun run check— all 13 checks passed