Add Flask login handler (SQL injection via data flow)#7
Open
appsechq-brian wants to merge 3 commits into
Open
Conversation
login_handler.py exposes user authentication over HTTP via Flask. Contains two SQL injection vectors: POST /login and GET /search, both feeding unsanitized request input directly into SQL queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
login_handler.py— a Flask web layer that exposes authentication over HTTP.Contains two SQL injection vulnerabilities where user-controlled input flows from HTTP request parameters directly into SQL query execution:
POST /login—request.form['username']andrequest.form['password']concatenated into SQLGET /search—request.args['name']concatenated into a LIKE queryDemo purpose
This PR demonstrates the delta scan catching a data flow SQL injection finding (CWE-89).
Unlike the MD5 findings in PR #6 (pattern-based — no source needed), SQL injection requires tracing a tainted source to a dangerous sink. Both source (
request.form.get(...)) and sink (cursor.execute(...)) are in this single new file, giving the SAST engine the complete chain within the diff.