Skip to content

Fix credential parsing and add crypto coverage#6

Merged
lextpf merged 2 commits into
lextpf:mainfrom
MukundaKatta:codex/reject-empty-parse-triples
May 15, 2026
Merged

Fix credential parsing and add crypto coverage#6
lextpf merged 2 commits into
lextpf:mainfrom
MukundaKatta:codex/reject-empty-parse-triples

Conversation

@MukundaKatta
Copy link
Copy Markdown

No description provided.

@lextpf
Copy link
Copy Markdown
Owner

lextpf commented May 15, 2026

Hi @MukundaKatta ,

Thanks for jumping in so quickly, having another pair of eyes on this is always appreciated! 😊
Nice cleanup on the parsing rules! Unfortunately I can’t merge as-is because the new code introduces three plain std::string hops of the creds, which breaks our “secure-string only” guideline. I’m all for the stricter trim and empty-field checks, though, so I'd like to jump in as co-author to fix this before merging.

If you'd like to dive in deeper as a contributer:

The project is a bit opaque about where assets live and it's a bit tricky to set up your own assets which means runtime testing can be quite cumbersome, if you'd like to test locally yourself here are two easy ways to get you up and running in case you want to be more hands-on for future issues:

What you might need How to get it Notes
Full pre-built project from your branch ➜ Add me on Discord (@lextpf). Unzip anywhere and run the executable.
Only the assets (if you want to build yourself) ➜ Add me on Discord (@lextpf). After cloning the repo, drop the assets/ folder from this ZIP into the repo root, then build.

Let me know if you need support and we can arrange something, and thanks again for volunteering and helping improve Seal, you're always welcome to work on future issues! 🦭

Alex

@lextpf lextpf force-pushed the codex/reject-empty-parse-triples branch from a9fe4a8 to a104731 Compare May 15, 2026 11:14
@lextpf
Copy link
Copy Markdown
Owner

lextpf commented May 15, 2026

I'm done with some minor corrections to keep parseTriples secret material in locked memory without plain string hops, the only owning copies are the wide basic_secure_string<wchar_t, A> produced by mk() so nothing leaks into pageable heap memory.

Thanks again for volunteering and helping improve Seal, you're always welcome to work on future issues! 🦭

Alex

@lextpf lextpf merged commit da2b385 into lextpf:main May 15, 2026
2 of 3 checks passed
@lextpf lextpf self-assigned this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants