Support for function update_deadline in Python target#558
Open
byeonggiljun wants to merge 6 commits intomainfrom
Open
Support for function update_deadline in Python target#558byeonggiljun wants to merge 6 commits intomainfrom
update_deadline in Python target#558byeonggiljun wants to merge 6 commits intomainfrom
Conversation
byeonggiljun
force-pushed
the
python-update-deadline
branch
from
bbbeb4e to
3e9e32a
Compare
byeonggiljun
requested review from
Jakio815,
edwardalee and
hokeun
and removed request for
edwardalee
Jakio815
approved these changes
Feb 9, 2026
edwardalee
approved these changes
Feb 10, 2026
Contributor
edwardalee
left a comment
edwardalee
left a comment
There was a problem hiding this comment.
LGTM! Some small editing suggestions...
Comment on lines
+111
to
+112
| * Therefore, you need to invoke check_deadline after | ||
| * update the deadline through this function to confirm |
Contributor
There was a problem hiding this comment.
Suggested change
| * Therefore, you need to invoke check_deadline after | |
| * update the deadline through this function to confirm | |
| * Therefore, you may want to invoke check_deadline after | |
| * updating the deadline through this function to confirm |
| * @param self The Python object of the reactor. | ||
| * @param args contains: | ||
| * - updated_deadline: The updated deadline. | ||
| * @return Py_None |
Contributor
There was a problem hiding this comment.
Suggested change
| * @return Py_None | |
| * @return Py_None or NULL if an error occurs. |
Contributor
There was a problem hiding this comment.
This should be changed to master after the companion merge occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the function
update_deadlinein the Python target.Companion lingua-franca PR: lingua-franca/pull/2590
Companion lf-python-support: lf-lang/lf-python-support#30
The newly introduced function py_update_deadline parses the deadline value from Python as a double and converts it to uint64_t to support fractional time values (e.g., SEC(0.5)).
Other Python APIs that take time values (e.g., schedule()) raise a type error when given floating-point arguments; extending fractional-time support to those APIs will be done in other PRs.