Open
Conversation
Co-authored-by: Renato Fernandes <renato@innovaro.com.br>
…pDomains} by @arthuredelstein Co-authored-by: Erwan Jugand <47392755+erwanjugand@users.noreply.github.com>
…nition by @WanGe2000 Co-authored-by: 周翔 <zhouxiang@wanjiadongli.com>
…ng from Custom to custom by @daisuke-awaji
…return Promises by @sosoba
…s-fail-on-warn by @jdufresne
Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com> Co-authored-by: Isabel Duan <isabelduan@microsoft.com> Co-authored-by: Frank Elsinga <frank@elsinga.de>
…emove readable-str… by @Delagen
…4366) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Holger Jeromin <Holger Jeromin mailgithub@katur.de>
Co-authored-by: nathanhleung <nathanhleung@users.noreply.github.com>
…structor not instance by @forivall
…roper v4 types by @hkleungai
Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…xport in v3, add missing erorr codes, add emitting 'error' event by @pazaderey Co-authored-by: Петр Задерей <zaderey@trueconf.ru>
Co-authored-by: manz <manz@users.noreply.github.com>
…ex-Arc Co-authored-by: Victor <doc999tor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test YOUR_PACKAGE_NAME.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present and it shouldn't have any additional or disabling of rules. Just content as{ "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.If removing a declaration:
notNeededPackages.json.