Add ignored_tables for column reordering.#19
Open
AndBobsYourUncle wants to merge 1 commit intolfittl:masterfrom
Open
Add ignored_tables for column reordering.#19AndBobsYourUncle wants to merge 1 commit intolfittl:masterfrom
AndBobsYourUncle wants to merge 1 commit intolfittl:masterfrom
Conversation
Collaborator
|
@AndBobsYourUncle Hi there. Is this still something you're interested in having? If so, is it still an issue? Could you expand a bit further on the use case including perhaps a positive and negative example where you want the ignored_tables behavior to apply, and one where you don't? For example you might choose to write this as a little bit of documentation showing how to use it. That might help in understanding the use case as well. If there's no response after maybe a month, we'll likely close this issue out. Thanks! |
haiderRizvii
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to ignore certain tables when doing column reordering.
Having this feature is particularly useful when there are Postgres DB functions (or other such things) that rely on implied column names from the ordering of the values in the query.
In particular, there is a case where a Postgres function in our project has an INSERT statement like this:
INSERT INTO some_table VALUES(1, 'some_data', 2);The columns are implied from the ordering, so if the ordering changes, this breaks the assumption. In CircleCI, the
structure.sqlis used to initialize the test DB, so integrated testing fails with the new column ordering.