Split primary_keys and sequences cleanups#23
Open
nvanoorschot wants to merge 3 commits intolfittl:masterfrom
Open
Split primary_keys and sequences cleanups#23nvanoorschot wants to merge 3 commits intolfittl:masterfrom
nvanoorschot wants to merge 3 commits intolfittl:masterfrom
Conversation
Collaborator
|
@nvanoorschot Is this still a gem you use, and is this PR something you're still interested in? I'm helping maintain the gem now so doing some housekeeping. Thanks. |
haiderRizvii
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced a primary key into my schema with a
character varyingas datatype but stillidas it's name. In order for this to work I had to disable theignore_idsfunctionality, which is a shame since that functionality does a good job of cleaning up de sql file.In order to make it work I separated the logic that handles primary keys from the logic that handles sequences. This allows to have a primary key with any datatype and any column name and still does the cleanup correctly. As a side benefit it now recognizes the primary key of the
ar_internal_metadatatable, which is namedkeyinstead ofid.There's still room for improvement on the sequences bit but that falls outside the scope of this PR.