Fix: Set correct make targets for multi-arch tests#148
Merged
tykeal merged 1 commit intolfreleng-actions:mainfrom Mar 4, 2026
Merged
Conversation
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
March 4, 2026 11:04
View session
There was a problem hiding this comment.
Pull request overview
Updates the test workflow’s multi-arch job to run the correct Makefile targets so NSS/NSPR dependencies are installed and environment variables are exported before building projects that require NSS (e.g., python-nss-ng).
Changes:
- Adjust
make_argsin thetest-multi-arch-projectsjob to invokedeps-nss env-github-actionsinstead of passing a-j$(nproc)flag. - Update the adjacent workflow comment to be less specific about the number of projects.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ModeSevenIndustrialSolutions
force-pushed
the
fix/multi-arch-make-args
branch
from
9d4ab1c to
b974440
Compare
ModeSevenIndustrialSolutions
changed the title
Default make target was 'help', not 'deps-nss'. The NSS/NSPR dependencies were never installed before the Python build ran. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
ModeSevenIndustrialSolutions
force-pushed
the
fix/multi-arch-make-args
branch
from
b974440 to
614fa90
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
March 4, 2026 11:10
View session
Contributor
Author
|
Fixes failure on pull request: #145 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tykeal
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
test-multi-arch-projectsjob in the testing workflow was failing because NSS/NSPR dependencies were not being installed before the Python build.Problem
The
make_argswas set to"-j$(nproc)"which ran the Makefile's defaulthelptarget — printing usage info but not installing anything. The meson build then failed because thenssdependency could not be found:Fix
Update
make_argsto"deps-nss env-github-actions"which:deps-nss— Builds and installs NSS/NSPR from sourceenv-github-actions— ExportsPKG_CONFIG_PATHandLD_LIBRARY_PATHtoGITHUB_ENVThis matches how the python-nss-ng project's own CI invokes the build action.
Related
MULTI_ARCH_TEST_PROJECTSrepository variable has also been updated to remove the archivedpython-nss-1.0.1project