Open
Conversation
Author
|
Just saw one of the last pull request on the null params : I don't know if it's the normal behavior, but from my point of view passing null to a function for a specific behavior wouldn't be a good practice.. |
Owner
Please note that this repository only contains typings, not code. So any complaints about the code style should go to the upstream repository. Also: Your pull request contains actual code, not typings. As such, I kindly ask you to review your pull request and remove the included implementation code to avoid conflicts. |
undo indentation changes correct wrong types
5432093 to
025a546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added class attributes that were missing from the typing from the last version of mxgraph (cf: diff)
Changed some params that should be optionnal, to be optionnal.
Correced some params typing that should not be alowwed to be null.
Some indentation corrections.