Fix connect scanner host detection issue#12#28
Open
lokiee0 wants to merge 1 commit intoliamg:masterfrom
Open
Conversation
- Fix host detection logic in connect scanner where hosts were incorrectly reported as down when ports were closed but host was responding - Improve channel handling with buffered channels and proper port counting - Add mutex protection for concurrent latency updates - Better error classification for connection states: - Connection refused/reset -> PortClosed (host up, port closed) - Timeout/no route -> PortFiltered (host down or filtered) - Other errors -> PortUnknown (host likely down) - Set latency on first port response to ensure host is detected as up - Add comprehensive tests for host detection scenarios This fixes the issue where 'furious -s connect github.com' would incorrectly report 'Host is down' when the host was actually up but ports were closed. Fixes liamg#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where 'furious -s connect github.com' would incorrectly report 'Host is down' when the host was actually up but ports were closed.
Fixes #12