Fix filtered ports detection in SYN scanner#7#30
Open
lokiee0 wants to merge 1 commit intoliamg:masterfrom
Open
Fix filtered ports detection in SYN scanner#7#30lokiee0 wants to merge 1 commit intoliamg:masterfrom
lokiee0 wants to merge 1 commit intoliamg:masterfrom
Conversation
- Add proper tracking of responded vs non-responded ports in SYN scanner - Mark ports that don't respond after timeout as filtered (not ignored) - Add buffered channels to prevent blocking during port classification - Improve connect scanner error classification for filtered ports: - Timeouts -> PortFiltered (firewall dropping packets) - Connection refused/reset -> PortClosed (host up, port closed) - Network unreachable -> PortFiltered (routing/firewall issues) - Add comprehensive tests for port state classification - Add mutex protection for concurrent port tracking - Update README with detailed port state documentation This ensures all scanned ports are properly classified as open, closed, or filtered, matching nmap's behavior. Previously, non-responding ports in SYN scans were simply ignored instead of being marked as filtered. Fixes liamg#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures all scanned ports are properly classified as open, closed, or filtered, matching nmap's behavior. Previously, non-responding ports in SYN scans were simply ignored instead of being marked as filtered.
Fixes #7